Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default items per page setting in options #351

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

I-Al-Istannen
Copy link
Contributor

@I-Al-Istannen I-Al-Istannen commented Aug 5, 2023

Previously, as noted by @Garmelon, the tables for the run comparison and measurement showed 200 rows, but the row selection checkbox was stuck at 5:
grafik

The cause for this odd behaviour is that the available options do not include the new default set in a PR a while ago, disallowing it to be selected. An easy fix is to just set the possible options and include the default :)
grafik

Feel free to bikeshed the possible options.

@I-Al-Istannen I-Al-Istannen added bug Something is or was not working correctly frontend Concerns the frontend labels Aug 5, 2023
@I-Al-Istannen I-Al-Istannen requested a review from Kha August 5, 2023 19:48
@I-Al-Istannen I-Al-Istannen self-assigned this Aug 5, 2023
@I-Al-Istannen I-Al-Istannen force-pushed the fix/footer-items-per-page-options branch from 547b755 to c48e8de Compare August 5, 2023 21:26
@Kha Kha merged commit f8196ff into main Aug 6, 2023
5 checks passed
@Kha Kha deleted the fix/footer-items-per-page-options branch August 6, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is or was not working correctly frontend Concerns the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants